Skip to content

fix: resolve autofix Biome specificity diagnostics - #1836

Merged
yamcodes merged 1 commit into
devfrom
yamcodes-fix-autofix-lint-debt
Sep 11, 2026
Merged

fix: resolve autofix Biome specificity diagnostics#1836
yamcodes merged 1 commit into
devfrom
yamcodes-fix-autofix-lint-debt

Conversation

@yamcodes

Copy link
Copy Markdown
Owner

Summary

  • preserve benchmark table styling while satisfying Biome specificity ordering
  • fix the pre-existing autofix.ci failure in viewer.html

Validation

  • git diff --check
  • Confirmed CI diagnostics from run 34628606400
  • Local Biome execution blocked because pnpm 12.0.0 is unavailable for macOS arm64 in the configured registry

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@changeset-bot

changeset-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 936eb65

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • skills/create-skill/eval-viewer/viewer.html — qualify .benchmark-table th/td rules with a table. element selector to satisfy Biome's CSS specificity-ordering diagnostic that autofix.ci was flagging.

The change raises selector specificity from (0,1,1) to (0,1,2) purely to satisfy the lint. I verified it is behaviorally inert: every benchmark table is rendered as <table class="benchmark-table"> (viewer.html:1146, 1215, 1282), so the added element qualifier always matches, and no competing rules are affected (the only other table rules target .output-file-content table). The autofix check now passes on the head commit, confirming the reported diagnostic is resolved, and the rest of CI is green. No changeset required — this is internal skill tooling, not a published package.

Pullfrog  | View workflow run | Using DeepSeek Flash (free via Pullfrog for OSS) | 𝕏

@yamcodes
yamcodes merged commit 7a95a19 into dev Sep 11, 2026
17 checks passed
@yamcodes
yamcodes deleted the yamcodes-fix-autofix-lint-debt branch September 11, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant